Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move over the resolver framework from Resolution. #5380

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Move over the resolver framework from Resolution. #5380

merged 1 commit into from
Aug 26, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Aug 25, 2022 •
edited
Loading

Changes

Part of #4710

As with #5372, little to no code changes at this point. This code is basically identical to https://github.com/tektoncd/resolution/tree/main/pkg/resolver/framework modulo package names.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@abayer
Move over the resolver framework from Resolution.
ceccf78 
Part of tektoncd#4710

As with tektoncd#5372, little to no code changes at this point.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2022
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 25, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 25, 2022
@abayer
Copy link
Contributor Author

abayer commented Aug 25, 2022

/assign @chitrangpatel @dibyom @pritidesai @jerop @lbernick @vdemeester

@tekton-robot
Copy link
Collaborator

@abayer: GitHub didn't allow me to assign the following users: chitrangpatel.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @chitrangpatel @dibyom @pritidesai @jerop @lbernick @vdemeester

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/framework/configstore.go Do not exist 30.0%
pkg/resolution/resolver/framework/controller.go Do not exist 55.4%
pkg/resolution/resolver/framework/fakeresolver.go Do not exist 90.0%
pkg/resolution/resolver/framework/reconciler.go Do not exist 72.7%

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@tekton-robot tekton-robot merged commit b7ec160 into tektoncd:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@vdemeester vdemeester

@pritidesai pritidesai

@dibyom dibyom

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abayer @tekton-robot @lbernick @jerop @vdemeester @pritidesai @dibyom